Update schema to NWB 2.10#300
Open
oruebel wants to merge 10 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the embedded, auto-generated NWB/HDMF schema specifications used by AqNWB to align with the latest upstream releases referenced in Issue #298.
Changes:
- Updated the NWB core schema spec to version 2.10.0, including new/updated schema components (e.g.,
nwb.eventand updates undernwb.file,nwb.misc,nwb.image,nwb.behavior). - Updated the HDMF common schema spec to version 1.9.0, including adding the
resourcesspec (HERD external resources tables) underhdmf-common. - Updated the HDMF experimental schema spec to version 0.6.0, adjusting the namespace contents accordingly.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/spec/core.hpp | Bumps core schema to NWB 2.10.0 and incorporates new/updated core spec content (including nwb.event and updated NWBFile structure). |
| src/spec/hdmf_common.hpp | Bumps HDMF common schema to 1.9.0 and adds the resources specification (HERD) to the namespace. |
| src/spec/hdmf_experimental.hpp | Bumps HDMF experimental schema to 0.6.0 and updates namespace schema sources accordingly. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
=======================================
Coverage 84.52% 84.52%
=======================================
Files 57 57
Lines 2591 2591
Branches 332 332
=======================================
Hits 2190 2190
Misses 401 401 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@rly note the changes to the files in "src/spec" are auto-generated via scripts so you can mostly ignore those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #298
Update schema version to the latest releases
spec/core.hppto NWB schema 2.10spec/hdmf_common.hppto schema version 1.9spec/hdmf_experimental.hppto schema version 0.6MeaningsTable.targetis being changed to an object reference attribute and should be changed here accordingly before merge. See Change MeaningsTable.target from a link to an object-reference attribute hdmf-dev/hdmf-common-schema#97